Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pump-controller-app example app with OTA #15633

Merged
merged 11 commits into from
Mar 9, 2022
Merged

Update pump-controller-app example app with OTA #15633

merged 11 commits into from
Mar 9, 2022

Conversation

tlykkeberg-grundfos
Copy link
Contributor

Problem

  • The OTA feature is not enabled on the pump-controller-app example app
  • The pump-controller-app.zap file is not fully spec. compliant

Change overview

  • Enabled the OTA feature by:
    • Adding OTA clusters to the zap file
    • Added handling code to the AppTask.cpp for pump-controller-app main application
    • Enabled feature in the args.gni file
  • Cleaned up the pump-controller-app.zap file:
    • Removed any old unneeded clusters
    • Added missing clusters
    • Re-ran the zap_regen_all.py script

Testing

  • Build the pump-controller-app for cc13x2x7_26x2x7 and verified it could run
  • Re-ran the zap_regen_all.py script and verified the build process of pump-controller-app

@restyled-io restyled-io bot mentioned this pull request Feb 28, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15633: Size comparison from 3e476eb to baeb1c5

Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 3e476eb baeb1c5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 599542 0 0.0
.app_xip_area 504388 504388 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 557614 0 0.0
.app_xip_area 463996 463996 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578138 0 0.0
.app_xip_area 475088 475088 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 916516 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 916508 0 0.0
BRD4161A+rpc (read only) 946604 946604 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 946596 0 0.0
lock-app BRD4161A+wf200 (read only) 986436 986436 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 986428 0 0.0
window-app BRD4161A (read only) 850596 850596 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 850588 0 0.0
esp32 all-clusters-app c3devkit (read only) 956534 956534 0 0.0
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956534 956534 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004671 1004671 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999287 999287 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 691904 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 606700 0 0.0
lock k32w061+release (read/write) 695176 695176 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 609724 0 0.0
linux all-clusters-app debug (read only) 2394761 2394761 0 0.0
(read/write) 144696 144696 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 204709 204709 0 0.0
.text 2027282 2027282 0 0.0
bridge-app debug+rpc (read only) 1720741 1720741 0 0.0
(read/write) 92744 92744 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141460 141460 0 0.0
.text 1463477 1463477 0 0.0
chip-tool debug (read only) 9003269 9003269 0 0.0
(read/write) 298816 298816 0 0.0
.bss 40448 40448 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 251144 251144 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 481173 481173 0 0.0
.text 7913189 7913189 0 0.0
chip-tool-ipv6only arm64 (read only) 8757372 8757372 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296840 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456996 456996 0 0.0
.text 7435092 7435092 0 0.0
door-lock-app debug (read only) 1936305 1936305 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173532 173532 0 0.0
.text 1614290 1614290 0 0.0
lighting-app debug+rpc (read only) 2071137 2071137 0 0.0
(read/write) 124496 124496 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166097 166097 0 0.0
.text 1749586 1749586 0 0.0
ota-provider-app debug (read only) 1868393 1868393 0 0.0
(read/write) 114800 114800 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158707 158707 0 0.0
.text 1559122 1559122 0 0.0
ota-requestor-app debug (read only) 1879369 1879369 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152420 152420 0 0.0
.text 1578114 1578114 0 0.0
shell debug (read only) 2362977 2362977 0 0.0
(read/write) 147176 147176 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204658 204658 0 0.0
.text 2001762 2001762 0 0.0
thermostat-no-ble arm64 (read only) 2162916 2162916 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132964 0 0.0
.text 1811648 1811648 0 0.0
tv-app debug (read only) 2589505 2589505 0 0.0
(read/write) 148632 148632 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198653 198653 0 0.0
.text 2217090 2217090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350140 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1312740 0 0.0
p6 all-clusters-app default (read/write) 2488104 2488104 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1446368 0 0.0
light-app default (read/write) 2395304 2395304 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1353568 0 0.0
lock-app default (read/write) 2358880 2358880 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317144 0 0.0
qpg lighting-app qpg6105+debug (read only) 601168 601168 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595848 595848 0 0.0
lock-app qpg6105+debug (read only) 566964 566964 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 561644 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883086 883086 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623942 623942 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15633: Size comparison from 235a4ac to ee74a5b

Increases above 0.2%:

platform target config section 235a4ac ee74a5b change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Increases (1 build for nrfconnect)
platform target config section 235a4ac ee74a5b change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 235a4ac ee74a5b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599590 599590 0 0.0
.app_xip_area 504436 504436 0 0.0
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557622 557622 0 0.0
.app_xip_area 464004 464004 0 0.0
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578146 578146 0 0.0
.app_xip_area 475096 475096 0 0.0
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916532 916532 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916524 916524 0 0.0
BRD4161A+rpc (read only) 946612 946612 0 0.0
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946604 946604 0 0.0
lock-app BRD4161A+wf200 (read only) 986444 986444 0 0.0
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986436 986436 0 0.0
window-app BRD4161A (read only) 850612 850612 0 0.0
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850604 850604 0 0.0
esp32 all-clusters-app m5stack (read only) 1004719 1004719 0 0.0
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999335 999335 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691908 691908 0 0.0
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606704 606704 0 0.0
lock k32w061+release (read/write) 695180 695180 0 0.0
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609728 609728 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8757580 8757580 0 0.0
(read/write) 412049 412049 0 0.0
.bss 58673 58673 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296848 296848 0 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 457028 457028 0 0.0
.text 7435236 7435236 0 0.0
thermostat-no-ble arm64 (read only) 2163444 2163444 0 0.0
(read/write) 148577 148577 0 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132996 132996 0 0.0
.text 1812128 1812128 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350148 2350148 0 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312748 1312748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038959 1075263 36304 3.5
bss 125756 127608 1852 1.5
rodata 135904 141808 5904 4.3
text 700088 728444 28356 4.1
p6 all-clusters-app default (read/write) 2488224 2488224 0 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446488 1446488 0 0.0
light-app default (read/write) 2395440 2395440 0 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353704 1353704 0 0.0
lock-app default (read/write) 2359000 2359000 0 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317264 1317264 0 0.0
qpg lighting-app qpg6105+debug (read only) 601212 601212 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595892 595892 0 0.0
lock-app qpg6105+debug (read only) 566976 566976 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561656 561656 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883138 883138 0 0.0
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623992 623992 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15633: Size comparison from cd44d83 to 14f0843

Increases above 0.2%:

platform target config section cd44d83 14f0843 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
Increases (1 build for nrfconnect)
platform target config section cd44d83 14f0843 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cd44d83 14f0843 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600022 600022 0 0.0
.app_xip_area 504796 504796 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558010 558010 0 0.0
.app_xip_area 464320 464320 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578430 578430 0 0.0
.app_xip_area 475308 475308 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917012 917012 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917004 917004 0 0.0
BRD4161A+rpc (read only) 947096 947096 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947088 947088 0 0.0
lock-app BRD4161A+wf200 (read only) 986828 986828 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986820 986820 0 0.0
window-app BRD4161A (read only) 850940 850940 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850932 850932 0 0.0
esp32 all-clusters-app m5stack (read only) 1005191 1005191 0 0.0
(read/write) 458344 458344 0 0.0
.dram0.bss 68168 68168 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999807 999807 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692208 692208 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606932 606932 0 0.0
lock k32w061+release (read/write) 695568 695568 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610052 610052 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8723956 8723956 0 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405684 7405684 0 0.0
thermostat-no-ble arm64 (read only) 2165476 2165476 0 0.0
(read/write) 148657 148657 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75064 75064 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133140 133140 0 0.0
.text 1814016 1814016 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350452 2350452 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313052 1313052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
p6 all-clusters-app default (read/write) 2488704 2488704 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1446968 1446968 0 0.0
light-app default (read/write) 2395880 2395880 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354144 1354144 0 0.0
lock-app default (read/write) 2359408 2359408 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317672 1317672 0 0.0
qpg lighting-app qpg6105+debug (read only) 601608 601608 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read only) 567324 567324 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562004 562004 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883682 883682 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 624464 624464 0 0.0

@tlykkeberg-grundfos
Copy link
Contributor Author

The Darwin / Build Darwin fails in some way, but I can't seem to figure out why and what it is about?

@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15633: Size comparison from c8bd017 to 172f9eb

Increases above 0.2%:

platform target config section c8bd017 172f9eb change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
Increases (1 build for nrfconnect)
platform target config section c8bd017 172f9eb change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c8bd017 172f9eb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600022 600022 0 0.0
.app_xip_area 504796 504796 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558010 558010 0 0.0
.app_xip_area 464320 464320 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578430 578430 0 0.0
.app_xip_area 475308 475308 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917012 917012 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917004 917004 0 0.0
BRD4161A+rpc (read only) 947080 947080 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947072 947072 0 0.0
lock-app BRD4161A+wf200 (read only) 986812 986812 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986804 986804 0 0.0
window-app BRD4161A (read only) 850940 850940 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850932 850932 0 0.0
esp32 all-clusters-app m5stack (read only) 1005187 1005187 0 0.0
(read/write) 458344 458344 0 0.0
.dram0.bss 68168 68168 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999803 999803 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692208 692208 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606932 606932 0 0.0
lock k32w061+release (read/write) 695568 695568 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610052 610052 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8723956 8723956 0 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405684 7405684 0 0.0
thermostat-no-ble arm64 (read only) 2165444 2165444 0 0.0
(read/write) 148657 148657 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75064 75064 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133140 133140 0 0.0
.text 1813984 1813984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350452 2350452 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313052 1313052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
p6 all-clusters-app default (read/write) 2488704 2488704 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1446968 1446968 0 0.0
light-app default (read/write) 2395880 2395880 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354144 1354144 0 0.0
lock-app default (read/write) 2359392 2359392 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317656 1317656 0 0.0
qpg lighting-app qpg6105+debug (read only) 601608 601608 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read only) 567324 567324 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562004 562004 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883698 883698 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 624478 624478 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@tlykkeberg-grundfos Can you resolve conflicts here? Looks like it's ready to go, thanks!

@tlykkeberg-grundfos
Copy link
Contributor Author

@woody-apple I have just rebased and pushed. Sp now the conflicts should have been resolved. Am I too late ?:-)

@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

PR #15633: Size comparison from 66aef3e to b08b1aa

Full report (10 builds for cyw30739, p6, qpg, telink)
platform target config section 66aef3e b08b1aa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600618 600618 0 0.0
.app_xip_area 505392 505392 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558614 558614 0 0.0
.app_xip_area 464924 464924 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579394 579394 0 0.0
.app_xip_area 476008 476008 0 0.0
.bss 85780 85780 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
p6 all-clusters-app default (read/write) 2489552 2489552 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1447816 1447816 0 0.0
light-app default (read/write) 2396728 2396728 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354992 1354992 0 0.0
lock-app default (read/write) 2360240 2360240 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1318504 1318504 0 0.0
qpg lighting-app qpg6105+debug (read only) 602284 602284 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91192 91192 0 0.0
.data 1132 1132 0 0.0
.text 596964 596964 0 0.0
lock-app qpg6105+debug (read only) 567984 567984 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91200 91200 0 0.0
.data 1084 1084 0 0.0
.text 562664 562664 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 884222 884222 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 625174 625174 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

@tlykkeberg-grundfos Sadly it appears so :( Still conflicts in place :(

@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15633: Size comparison from 16c7fea to fe3398b

Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 16c7fea fe3398b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601802 601802 0 0.0
.app_xip_area 506344 506344 0 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559722 559722 0 0.0
.app_xip_area 465800 465800 0 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581910 581910 0 0.0
.app_xip_area 478308 478308 0 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920868 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920860 0 0.0
BRD4161A+rpc (read only) 949688 949688 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949680 0 0.0
window-app BRD4161A (read only) 853888 853888 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853880 0 0.0
esp32 all-clusters-app c3devkit (read only) 957506 957506 0 0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957506 957506 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012255 1012255 0 0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006871 1006871 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694852 694852 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609384 609384 0 0.0
lock k32w061+release (read/write) 696456 696456 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611012 611012 0 0.0
linux all-clusters-app debug (read only) 2426809 2426809 0 0.0
(read/write) 145600 145600 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78360 78360 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205509 205509 0 0.0
.text 2058434 2058434 0 0.0
bridge-app debug+rpc (read only) 1731837 1731837 0 0.0
(read/write) 92560 92560 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474213 1474213 0 0.0
chip-tool debug (read only) 9758533 9758533 0 0.0
(read/write) 338488 338488 0 0.0
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305816 305816 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8508373 8508373 0 0.0
chip-tool-ipv6only arm64 (read only) 9430548 9430548 0 0.0
(read/write) 454177 454177 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 351000 0 0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486556 0 0.0
.text 7940244 7940244 0 0.0
door-lock-app debug (read only) 1946161 1946161 0 0.0
(read/write) 119008 119008 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1623954 1623954 0 0.0
lighting-app debug+rpc (read only) 2078233 2078233 0 0.0
(read/write) 124376 124376 0 0.0
.bss 51264 51264 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66040 66040 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165852 165852 0 0.0
.text 1756866 1756866 0 0.0
ota-provider-app debug (read only) 1879017 1879017 0 0.0
(read/write) 114640 114640 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57416 57416 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1569490 1569490 0 0.0
ota-requestor-app debug (read only) 1901001 1901001 0 0.0
(read/write) 117352 117352 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59112 59112 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154188 154188 0 0.0
.text 1596850 1596850 0 0.0
shell debug (read only) 2392921 2392921 0 0.0
(read/write) 149752 149752 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205458 205458 0 0.0
.text 2031010 2031010 0 0.0
thermostat-no-ble arm64 (read only) 2174612 2174612 0 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823312 0 0.0
tv-app debug (read only) 2617049 2617049 0 0.0
(read/write) 250648 250648 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2243698 2243698 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1151827 0 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785544 785544 0 0.0
p6 all-clusters-app default (read/write) 2494064 2494064 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452328 0 0.0
light-app default (read/write) 2397504 2397504 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355768 0 0.0
lock-app default (read/write) 2360936 2360936 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888978 888978 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628342 628342 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 6081193 into project-chip:master Mar 9, 2022
@tlykkeberg-grundfos tlykkeberg-grundfos deleted the feature/add-ota-for-pump-controller-app branch March 10, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlykkeberg-grundfos @woody-apple @Damian-Nordic @bzbarsky-apple